Object oriented solution? #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikegee
reviewed
Dec 2, 2016
|
|
||
| def count_words | ||
| parsed_text.each do |word| | ||
| if word_counts.key?(word) |
Member
There was a problem hiding this comment.
If you instantiate the word_counts hash with a default value of 0, you wouldn't need to check if the word has already been seen.
| end | ||
|
|
||
| def sorted_counts | ||
| word_counts.sort_by {|_key, value| -value} |
Member
There was a problem hiding this comment.
I bet there are people that wouldn't think this is readable, but I love the simplicity of it.
It would be a slight improvement to give _key and value more intention-revealing names. _word and count, I suppose.
There was a problem hiding this comment.
+1. Variables should have meaningful names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is close. The parser still counts dashes and it couldn't hurt to write tests for the TextParser class.