Skip to content

Ready for evaluation #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ritchedt wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Ready for evaluation #32

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68320c9
created new files for building and testing
ritchedt Nov 5, 2016
886dbaa
Revert "created new files for building and testing"
ritchedt Nov 5, 2016
6104107
created class and empty methods to use
ritchedt Nov 5, 2016
294b84a
Ready for evaluation
ritchedt Nov 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions lib/countwords.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
class CountWords

attr_accessor :word_count
Copy link
Member

@mikegee mikegee Nov 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This word_count isn't used yet. You can probably delete all the @@s and then you would be using it.


def count_words_from_file(file)
count_file = File.open(file, "r")
count_file.each_line do |line|
next if line.empty?
@@word_count = Hash.new
Copy link
Member

@mikegee mikegee Nov 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we start with a fresh Hash on every line. Is that a bug?

word = line.split
word.each do |wrd|
next if wrd !~ /(\w+)/
wrd = wrd[/(\w+)/]
Copy link
Member

@mikegee mikegee Nov 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splitting the line, iterating, and making sure each word matches \w+, can be simplified using String#scan.

if @@word_count.has_key?(wrd)
@@word_count[wrd] = @@word_count[wrd] + 1
else
@@word_count[wrd] = 1
end
end
display_word_count_asc
Copy link
Member

@mikegee mikegee Nov 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to not display while you build up the data. How about if the client code (outside this class) asks for the display something like:

word_counter = CountWords.new
word_counter.count_words_from_file("speech.txt")
word_counter.display_word_count_asc

end

count_file.close
@@word_count
end

def display_word_count_asc
puts ""
puts "'''''"
@@word_count.sort{|a,b| a[1]<=>b[1]}.each { |word|
Copy link
Member

@mikegee mikegee Nov 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubyists tend to use {} for single line block, and do/end for multiline blocks.

Check out Rubocop for automated checks for stuff like this. It enforces this style guide.

puts "#{word[1]} - #{word[0]}"
}
puts "'''''"
end

end

def count_data
data = CountWords.new
data.count_words_from_file("speech.txt")
end

count_data