Skip to content

Sam's solution #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sampriddy wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Sam's solution #21

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
12bc942
Initial solution
Dec 13, 2015
5f7e92a
Move logic into functions with reasonable names
Dec 13, 2015
165e1f4
Move methods into a class
Dec 14, 2015
9b0a473
Fix problem with regex (failed to find one-letter words)
Dec 14, 2015
cf3aff3
Change WORDS_REGEX from class variable to constant in class scope
Dec 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions solution.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
TEXT = File.read('speech.txt')

def find_words text
words_regex = /\w+[a-z']*\w+/
Copy link
Member

@mikegee mikegee Dec 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would make a little more sense defined as a constant outside the method.

Copy link
Member

@jaybobo jaybobo Dec 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd probably be a good idea to encapsulate these methods in a class as well, no?

text.downcase.scan words_regex
end

def count_words words_array
Hash.new(0).tap do |word_count|
Copy link
Member

@jaybobo jaybobo Dec 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of .tap

words_array.each { |word| word_count[word] += 1 }
end
end

def sort_words words_frequency_hash
words_frequency_hash.sort_by { |word, count| -count }
Copy link
Member

@jaybobo jaybobo Dec 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Don't think I've seen anyone implement it this way before. I was putz'ing around with irb and {}.sort_by(&:last).reverse will do the same too.

end

def wordcount_print_format word
"#{word[1]} - #{word[0].capitalize}"
end

def print_sorted_word_counts sorted_words
sorted_words.each { |word| puts wordcount_print_format(word) }
end

words = find_words TEXT
word_freqs = count_words words
sorted_words = sort_words word_freqs
print_sorted_word_counts sorted_words