finished #40
Open
finished #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikegee
reviewed
May 16, 2018
| def show | ||
| if params[:id].start_with?("!") | ||
| @url = Url.find_by(:short_url => "http://localhost:3000/urls/#{params[:id]}") | ||
| @url.click_count += 1 |
Member
There was a problem hiding this comment.
I don't think this line persists the incremented count to the database.
mikegee
reviewed
May 16, 2018
source/app/models/url.rb
Outdated
| end | ||
|
|
||
| def shorten_url | ||
| self.short_url = "http://localhost:3000/urls/!#{(0..3).map{ rand(36).to_s(36) }.join}" |
Member
There was a problem hiding this comment.
Its probably better to save only the random "slug" at the end. That way, we can construct the URL correctly even if this app were deployed to a production environment.
mikegee
reviewed
May 16, 2018
| end | ||
|
|
||
| def show | ||
| if params[:id].start_with?("!") |
Member
There was a problem hiding this comment.
Let's try to make the router send these two kinds of requests to two controller actions. Let me know if you'd like some guidance on that.
mikegee
reviewed
May 17, 2018
|
|
||
| def show | ||
| @url = Url.find(params[:id]) | ||
| url_path(@url) |
Member
There was a problem hiding this comment.
I don't think this line does anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jaybobo