Hari's solution #36
Open
Hari's solution #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikegee
reviewed
Jan 30, 2018
| def route_me | ||
| url = Url.find_by_short_url params[:short_url] | ||
|
|
||
| if url.nil? |
Member
There was a problem hiding this comment.
I prefer if url (drop .nil?) to phrase things positively, and put the "happy path" code in the top of the if/else.
mikegee
reviewed
Jan 30, 2018
| if url.nil? | ||
| redirect_to root_path | ||
| else | ||
| url.update('click_count' => url.click_count + 1) |
Member
There was a problem hiding this comment.
ActiveRecord has a method for this kind of thing.
There's a subtle bug as currently written. Do you see it?
mikegee
reviewed
Jan 30, 2018
|
|
||
| def long_url_responds | ||
| link = URI.parse(long_url) | ||
| if link.is_a?(URI::HTTP) || link.is_a?(URI::HTTPS) |
Member
There was a problem hiding this comment.
This bit seems very similar to long_url.start_with? 'http://', 'https://' in the above method. I think a concept is duplicated here. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jaybobo