Use subrequest for functional LoggerFinisher tests #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to access helper code for tests.
These provide additional logic for functional form testing.
Use a regular subrequest to fetch and submit forms with data. This allows us to drop all kinds of mocking and fake environment setup. Also we do not need to know about the internals of the Form framework anymore. The hardest part was testing file uploads which evidently do not work with stream-based uploaded files. When using the StreamFactoryInterface to create one and "upload" such a file, Extbase/Form will not accept this file since there is no "tmp_name" internally. This only works with phyisically created temporary files just like we did before.
mbrodala
force-pushed
the
logger-finisher-test-sub-request
branch
from
26bb102 to
748b72e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.