Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is stay as draft until game is at a stage that it should be implemented, which means this pr is kept as draft if anyone needs it in future.
(note: I planned to request some assistance from artist channel for item icon, as the one I am using is compressed from bulba, but since pr is not accepted currently so it'll just be there for functionality)
balance team:
![image](https://private-user-images.githubusercontent.com/62000482/360561965-1d6c757e-5b21-47d5-abd4-38b19e53f92a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2ODQ0OTIsIm5iZiI6MTczOTY4NDE5MiwicGF0aCI6Ii82MjAwMDQ4Mi8zNjA1NjE5NjUtMWQ2Yzc1N2UtNWIyMS00N2Q1LWFiZDQtMzhiMTllNTNmOTJhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDA1MzYzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFhNGY3ODAzOTUyOTE3NWE5MjA1MTI5OWY1OGUyNjgxOTI2YWIzZWI3ZDQ3YTExYTUwNmRiNDVlMWMyZDljNDMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.qvy6jFo0zVMW-nQv4MPTuFXcwct-66XhBIykbsyxwNw)
What are the changes the user will see?
prob nothing right now as i have not added it into any pool
Why am I making these changes?
issue related
What are the changes from a developer perspective?
item's current effect:
Added code:
an item modifier (PreventStatLowerChanceModifier)
with modifier type (PreventStatLowerChanceModifierType)
a section checking clear amulet in stat-change-phase
Screenshots/Videos
(The item count is 10 in video for 100% chance to showcase that prevents stat drop, it's max at 5 for 50% actually. )
haze-reset-correctly.mp4
contrary-apply-correctly.mp4
How to test the changes?
run locally.
Checklist
I'm using
beta
as my base branchThere is no overlap with another PR?
The PR is self-contained and cannot be split into smaller PRs?
Have I provided a clear explanation of the changes?
Have I considered writing automated tests for the issue?
not yet
If I have text, did I add placeholders for them in locales?
Have I tested the changes (manually)?
npm run test
)but there is possibility that may randomly breaking tests... maybe?
Are the changes visual?