Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Item] add Clear Amulet #3664

Draft
wants to merge 5 commits into
base: beta
Choose a base branch
from
Draft

Conversation

allen925
Copy link
Contributor

@allen925 allen925 commented Aug 20, 2024

PR is stay as draft until game is at a stage that it should be implemented, which means this pr is kept as draft if anyone needs it in future.
(note: I planned to request some assistance from artist channel for item icon, as the one I am using is compressed from bulba, but since pr is not accepted currently so it'll just be there for functionality)

balance team:
image

What are the changes the user will see?

prob nothing right now as i have not added it into any pool

Why am I making these changes?

issue related

What are the changes from a developer perspective?

item's current effect:

  1. prevents carrier to drop stat 10% per stack up to max 50%,
  2. does not work for selfTarget moves like Close Combat,
  3. can be effected by haze.

Added code:
an item modifier (PreventStatLowerChanceModifier)
with modifier type (PreventStatLowerChanceModifierType)
a section checking clear amulet in stat-change-phase

Screenshots/Videos

(The item count is 10 in video for 100% chance to showcase that prevents stat drop, it's max at 5 for 50% actually. )

haze-reset-correctly.mp4
contrary-apply-correctly.mp4

How to test the changes?

run locally.

Checklist

  • I'm using beta as my base branch

  • There is no overlap with another PR?

  • The PR is self-contained and cannot be split into smaller PRs?

  • Have I provided a clear explanation of the changes?

  • Have I considered writing automated tests for the issue?
    not yet

  • If I have text, did I add placeholders for them in locales?

  • Have I tested the changes (manually)?

    • Are all unit tests still passing? (npm run test)
      but there is possibility that may randomly breaking tests... maybe?
      image
  • Are the changes visual?

    • Have I provided screenshots/videos of the changes?

@flx-sta flx-sta added the Item Affects an item label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Item Affects an item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants