[Enhancement] Preserve move PP when fusing

[knispeja]

What are the changes?

Move PP is now preserved when learning any moves that come from fusion. This is reflected on the move summary UI. Additionally, for the edge case when both members of the fusion have the same move known, the higher PP is used.

Why am I doing these changes?

Issue: #1284
I thought this issue was a good idea -- fusion order and what is retained is already confusing, I think it's best to limit that confusion where possible. It's also just nice for the player not to lose PP for "no reason".

What did change?

Added a PPUp override value that can be passed through into LearnMovePhase as well as Pokemon.setMove() that allows for moves to begin with non-zero values for ppUp. Provided this override value to the fusion move learning phase in pokemon.ts. I also moved PP calculation into a static method so PP could be calculated with PP Ups taken into account when a move hasn't been learned yet.

Screenshots/Videos

SplicePpTransfer.mp4

Note: to clarify the video above, Sand Attack has had a PP Max used on it, and that carries over during fusion.

How to test the changes?

Increase the drop rate of PP Up, PP Max, and DNA Splicer. Try different combinations -- there's a particular edge case when both know the same move with different PP.

Checklist

• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?

[flx-sta]

ℹ️ PR considered stale. No actions in the last 30 days.

---

❗ Feel free to ping me/comment if you want to re-open it