Fusesoc type #740
Fusesoc type #740
Conversation
|
Putting aside the fact that we have not yet defined how the various test types are to behave (parse, build, roundtrip, base, advanced and so on), the test file seems to comprise 4 groups of parse, roundtrip and build test cases that are identical but for variations in namespace, name and version values. Why? A few tests meant to fail (there are none here) would be more useful and informative. |
|
Oh, I was just copying the format of the tests in some other type already present, taking that for an appropriate level of effort. I'll see about adding some more. |
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks. Here are a few nits for your review... also I am not sure that the encoding of the namespace / matches the spec... can you double check?
tests/types/fusesoc-test.json
Outdated
| "expected_failure_reason": null | ||
| }, | ||
| { | ||
| "description": "Build test for PURL type: fusesoc", |
There was a problem hiding this comment.
There may be an extra space there?
tests/types/fusesoc-test.json
Outdated
| "expected_failure_reason": null | ||
| }, | ||
| { | ||
| "description": "Build test for PURL type: fusesoc", |
There was a problem hiding this comment.
Extra space in the description
types/fusesoc-definition.json
Outdated
| "version_definition": { | ||
| "requirement": "optional", | ||
| "native_name": "version", | ||
| "note": "The version is the semantic version of the fusesoc core. We would really like this to be required, but that breaks validation." |
There was a problem hiding this comment.
I am not sure you need this comment.... The fact that version is optional is a spec thing when you want to refer to a package without mentioning a version like in the CVE schema, or when using that with a VERS. What about this:
| "note": "The version is the semantic version of the fusesoc core. We would really like this to be required, but that breaks validation." | |
| "note": "The version is the semantic version of the fusesoc core." |
4 participants
This change adds a type for FuseSoC cores (see https://github.com/olofk/fusesoc).