-
Notifications
You must be signed in to change notification settings - Fork 210
tests: more cases for qualifier spec #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
tests: more cases for qualifier spec #738
Conversation
Signed-off-by: Jan Kowalleck <[email protected]>
johnmhoran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkowalleck The build and parse tests look accurate to me -- nice level of detail, too. 👍 My understanding is that we will not be using the roundtrip test_type, so those tests will need to be deleted.
why is this? I mean, the roundtrip exists for a very good reason: test canonicalization of string input. |
|
@jkowalleck We have been trying to figure out the use case for roundtrip - no decision has been made. Philippe described roundtrip as a shortcut for combining a set of parse and build tests. Could you explain more about the use case for roundtrip? Is it somehow equivalent to "validation" of a string input? |
I used it as "i get some PURL string input, and want to re-usue it with all normalizations and cleaning applied." |
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
caused by https://github.com/package-url/purl-spec/pull/730/files#r2493378205 and others