Skip to content

fix: Fix some issues with StringUtilBenchmark #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Fix some issues with StringUtilBenchmark #229

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bfb05b
fix: Fix some issues with `StringUtilBenchmark`
dwalluck Apr 2, 2025
2be9a81
Move data creation to a single method
dwalluck Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions src/test/java/com/github/packageurl/internal/StringUtilBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,43 +54,45 @@
@OutputTimeUnit(TimeUnit.MICROSECONDS)
@State(Scope.Benchmark)
public class StringUtilBenchmark {
private static final Random RANDOM = new Random();

private static final int DATA_COUNT = 1000;

private static final int DECODED_LENGTH = 256;

private static final byte[] UNRESERVED =
"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-._~".getBytes(StandardCharsets.US_ASCII);

@Param({"0", "0.1", "0.5"})
private double nonAsciiProb;

private String[] decodedData;
private String[] encodedData;
private String[] decodedData = {};

private String[] encodedData = {};

@Setup
public void setup() {
decodedData = createDecodedData();
encodedData = encodeData(decodedData);
createDecodedData();
createEncodedData();
Copy link
Contributor

@ppkarwasz ppkarwasz Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a big fan of methods that need to be called in a very precise order to work. What about merging these methods?

}

private String[] createDecodedData() {
Random random = new Random();
String[] decodedData = new String[DATA_COUNT];
private void createDecodedData() {
decodedData = new String[DATA_COUNT];
for (int i = 0; i < DATA_COUNT; i++) {
char[] chars = new char[DECODED_LENGTH];
for (int j = 0; j < DECODED_LENGTH; j++) {
if (random.nextDouble() < nonAsciiProb) {
chars[j] = (char) (Byte.MAX_VALUE + 1 + random.nextInt(Short.MAX_VALUE - Byte.MAX_VALUE - 1));
if (RANDOM.nextDouble() < nonAsciiProb) {
chars[j] = (char) (Byte.MAX_VALUE + 1 + RANDOM.nextInt(Short.MAX_VALUE - Byte.MAX_VALUE - 1));
} else {
chars[j] = (char) UNRESERVED[random.nextInt(UNRESERVED.length)];
chars[j] = (char) UNRESERVED[RANDOM.nextInt(UNRESERVED.length)];
}
}
decodedData[i] = new String(chars);
}
return decodedData;
}

private static String[] encodeData(String[] decodedData) {
String[] encodedData = new String[decodedData.length];
private void createEncodedData() {
encodedData = new String[decodedData.length];
for (int i = 0; i < encodedData.length; i++) {
encodedData[i] = StringUtil.percentEncode(decodedData[i]);
if (!StringUtil.percentDecode(encodedData[i]).equals(decodedData[i])) {
Expand All @@ -100,13 +102,12 @@ private static String[] encodeData(String[] decodedData) {
+ StringUtil.percentDecode(encodedData[i]));
}
}
return encodedData;
}

@Benchmark
public void baseline(Blackhole blackhole) {
for (int i = 0; i < DATA_COUNT; i++) {
byte[] buffer = decodedData[i].getBytes(StandardCharsets.UTF_8);
for (String decodedStr : decodedData) {
byte[] buffer = decodedStr.getBytes(StandardCharsets.UTF_8);
// Prevent JIT compiler from assuming the buffer was not modified
for (int idx = 0; idx < buffer.length; idx++) {
buffer[idx] ^= 0x20;
Expand Down