Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for service accounts as organization members #246

Open
wants to merge 3 commits into
base: 25.0.0_orgs_admin_ui
Choose a base branch
from
Open

Support for service accounts as organization members #246

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a28cb4f
Update getOrgMembers to support service accounts listing
kedare Jul 10, 2024
179c86c
Fix issues indicating in PR review
kedare Jul 16, 2024
9e29875
Fix parameter
kedare Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions js/apps/admin-ui/src/phaseII/orgs/useOrgFetcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,16 +167,18 @@ export default function useOrgFetcher(realm: string) {
first: number;
max: number;
search?: string;
includeServiceAccounts?: boolean;
};
async function getOrgMembers(
orgId: string,
{ first, max, search }: OrgMemberOptions = {
{ first, max, search, includeServiceAccounts }: OrgMemberOptions = {
first: 1,
max: 100,
max: 100
},
): Promise<MembersOf[]> {
let query = `first=${first}&max=${max}`;
query = search ? `${query}&search=${search}` : query;
query = includeServiceAccounts ? `${query}&includeServiceAccounts=${includeServiceAccounts}` : query;
pnzrr marked this conversation as resolved.
Show resolved Hide resolved
const resp = await fetchGet(`${baseUrl}/orgs/${orgId}/members?${query}`);
const result = await resp.json();
return result;
Expand Down