Skip to content

fix: prevent div-by-zero in evaluator when base_refusals is 0 #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
p-e-w merged 2 commits into from
Mar 13, 2026
+3 −1
Merged

fix: prevent div-by-zero in evaluator when base_refusals is 0 #225

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f335dcc
fix: prevent div-by-zero in evaluator when base_refusals is 0
cpagac Mar 13, 2026
8fc23d7
fix: cast refusals to float for type consistency" before hitting comm…
cpagac Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/heretic/evaluator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,9 @@ def get_score(self) -> tuple[tuple[float, float], float, int]:
kl_divergence_scale = self.settings.kl_divergence_scale
kl_divergence_target = self.settings.kl_divergence_target

refusals_score = refusals / self.base_refusals
refusals_score = (
refusals / self.base_refusals if self.base_refusals > 0 else refusals
Comment thread
cpagac marked this conversation as resolved.
Outdated
)

if kl_divergence >= kl_divergence_target:
kld_score = kl_divergence / kl_divergence_scale
Expand Down