Skip to content

nvme: CQEs with command-specific error 0 are acceptable #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

nvme: CQEs with command-specific error 0 are acceptable #965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/propolis/src/hw/nvme/bits.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,7 +714,7 @@ pub const IDENT_CNS_CONTROLLER: u8 = 0x1;
/// The type of value specified in the Status Field (SF) of a command completion.
///
/// See NVMe 1.0e Section 4.5.1.1 Status Code Type (SCT)
#[derive(Copy, Clone)]
#[derive(Copy, Clone, Debug, PartialEq)]
#[repr(u8)]
pub enum StatusCodeType {
Generic = 0,
Expand Down
2 changes: 1 addition & 1 deletion lib/propolis/src/hw/nvme/cmds.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,7 +985,7 @@ impl Completion {
/// Create an error Completion result with a specific type and status
pub fn specific_err(sct: StatusCodeType, status: u8) -> Self {
// success doesn't belong in an error
assert_ne!(status, bits::STS_SUCCESS);
assert_ne!((sct, status), (StatusCodeType::Generic, bits::STS_SUCCESS));

Self { dw0: 0, status: Self::status_field(sct, status) }
}
Expand Down
Loading