style(clippy): address some clippy warnings

[danieleades]

No description provided.

[ahl]

Thanks for your interest in contributing! We don't tend to find clippy-only fixes of much interest. The exception is if they pertain to generated code and the changes don't introduce disproportionate complexity. I'm also not sure what version of clippy you're using--I see a different set of nits in 1.92 for example.

[danieleades]

Thanks for your interest in contributing! We don't tend to find clippy-only fixes of much interest. The exception is if they pertain to generated code and the changes don't introduce disproportionate complexity. I'm also not sure what version of clippy you're using--I see a different set of nits in 1.92 for example.

There are a few more valuable changes sprinkled through here (such as shadowing nightly method names and addressing deprecations). Would you like to see them in a separate PR?

More generally I think addressing clippy warnings (or explicitly suppressing lints you don't like) is valuable in it's own right, since all the "noise" from lower value lints obscures more valuable ones that have a genuine impact. That's a personal view, and I appreciate it may not be yours