sled-agent-config-reconciler: actually call on_time_sync()#8509
Merged
jgallagher merged 1 commit intomainfrom Jul 2, 2025
Merged
sled-agent-config-reconciler: actually call on_time_sync()#8509jgallagher merged 1 commit intomainfrom
on_time_sync()#8509jgallagher merged 1 commit intomainfrom
Conversation
Contributor
Author
|
Tested on berlin: uptimes are back to reasonable. |
leftwo
reviewed
Jul 2, 2025
| "Notified metrics task that time is now synced", | ||
| ), | ||
| Err(e) => error!( | ||
| Err(e) => warn!( |
Contributor
There was a problem hiding this comment.
Why switch to a warn here?
Will we retry this? (I know that this is not part of the goal of the PR, just wondering)
Contributor
Author
There was a problem hiding this comment.
We will not retry this, but I don't think it's particularly detrimental to sled-agent itself, right? I can change it back if you think error! is better. I have a vague sense that those are pretty rare and usually near-fatal.
Contributor
Author
There was a problem hiding this comment.
(Merging to get the fix into main, but happy to open a PR switching this back if you disagree)
leftwo
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@askfongjojo noticed that our
uptimes on dogfood are all nonsense:I think #8064 introduced this. It shuffled around how time sync is checked and added a callback that the config-reconciler is supposed to run when it detects time has synchronized; that callback is responsible for rewriting
uptime(among other things), but it never actually executes the callback. This PR fixes that.However, we have some racklettes that are running commits that include #8064 that have reasonable uptimes. I'm not sure how that's possible - is there some other way
uptimecan be correct if sled-agent doesn't fix it?