Skip to content

[sled-agent-config-reconciler] Add DumpSetupTask #8146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

jgallagher
Copy link
Contributor

Adds a tokio task responsible for activating DumpSetup whenever the set of disks changes. This is analogous to the current StorageMonitor, with two mechanical changes:

  • It no longer makes sense to wait for changes to generation, because that covers the entire config (and usually will be bumped just for changes to the zones; e.g., during updates). We instead consume channels that contain the managed disks and keep our own "what was the last set of disks we used" to decide when to forward a change notification on to update_dumpdev_setup.
  • We consume two channels due to the split of internal vs external disks within the config reconciler.

Staged on top of #8140.

Base automatically changed from john/sled-agent-config-reconciler-zones to main May 14, 2025 17:21
@jgallagher jgallagher force-pushed the john/sled-agent-config-reconciler-dump-setup-task branch from 642d95a to 153e2ba Compare May 14, 2025 17:22
@jgallagher jgallagher merged commit ceedcce into main May 14, 2025
16 checks passed
@jgallagher jgallagher deleted the john/sled-agent-config-reconciler-dump-setup-task branch May 14, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants