-
Notifications
You must be signed in to change notification settings - Fork 43
Add id
column on tokens and sessions
#8137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
david-crespo
wants to merge
8
commits into
main
Choose a base branch
from
token-session-ids
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+415
−157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-crespo
commented
May 12, 2025
48c4c68
to
7f377d8
Compare
david-crespo
commented
May 13, 2025
@@ -957,7 +957,7 @@ authz_resource! { | |||
authz_resource! { | |||
name = "DeviceAccessToken", | |||
parent = "Fleet", | |||
primary_key = String, // token | |||
primary_key = { uuid_kind = AccessTokenKind }, | |||
roles_allowed = false, | |||
polar_snippet = FleetChild, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm realizing FleetChild
will probably have to change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8139
WIP. Everything compiles and existing tests work, but we are not yet testing retrieval by ID and we need to think about authz checks on the datastore functions for retrieving tokens and sessions by token string.
This PR would be a lot shorter if not for the fact that the
token
column was the primary key on both tables, so adding theid
requires a bunch of migration steps to change the primary key. There were also a lot of changes to code and tests around making things ID-centric instead of token-centric.id
col and changing primary key to thatTypedUuid
to session and token DB modelsauthz_resource!
andlookup_resource!
calls for new primary keySession
trait methods to useid
instead oftoken
FakeSession
implementations (one for unit tests, one for integration tests) to a) track sessions in aVec
instead of aHashMap
with token keys