Internal cleanup for boot disk/instance update #6738
Conversation
Greg and Eliza were both right in comments on #6585, but since these are both fully internal I didn't want to add another CI round trip there :)
| if params.create_params.boot_disk.is_none() { | ||
| return Ok(()); | ||
| } |
There was a problem hiding this comment.
Hmm...it occurs to me that it might be nicer to just change the make_saga_dag function to just not append a sic_set_boot_disk node if there is no boot disk param. Like, change this:
to:
if params.create_params.boot_disk.is_some() {
builder.append(set_boot_disk_action());
}That way, we would never do the forward or reverse action if there's no boot disk.
There was a problem hiding this comment.
... huh, i suppose that makes sense. i'd read something in one of the comments here about Steno not handling dynamically-shaped sagas, but the comment earlier about MAX_NICS_PER_INSTANCE makes me think i'd read something old without realizing it.
There was a problem hiding this comment.
Hm...a saga's DAG can definitely depend on its params, so it's possible that the comment either meant something else by "dynamically-shaped", or was just out of date...
Greg and Eliza were both right in comments on #6585, but since these are both fully internal I didn't want to add another CI round trip there :)