Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working eSPI for IPCC UART packets using oob message mechanism #1982

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

nathanaelhuffman
Copy link
Contributor

New FPGA, with FPGA-internal changes only to support IPCC over eSPI. No interface or register map changes, boots fine on ruby with grapefruit!

Copy link
Contributor

@Aaron-Hartwig Aaron-Hartwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know grapefruit is fast and loose, but I think there is value in pointing to where the collateral comes from (example). Otherwise right now we don't really know the origin. At very least we should have the Quartz commit somewhere. Ideally it would be a commit off main, but I'm not going to die on that hill for a dev system.

Copy link
Contributor

@Aaron-Hartwig Aaron-Hartwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nathanaelhuffman
Copy link
Contributor Author

I know grapefruit is fast and loose, but I think there is value in pointing to where the collateral comes from (example). Otherwise right now we don't really know the origin. At very least we should have the Quartz commit somewhere. Ideally it would be a commit off main, but I'm not going to die on that hill for a dev system.

Fixed with a link to the commit on quartz main, image was built off that commit by ci.

@nathanaelhuffman nathanaelhuffman merged commit 1c9803c into master Jan 17, 2025
125 checks passed
@nathanaelhuffman nathanaelhuffman deleted the oob-espi-uart branch January 17, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants