gimlet-seq-server: start driving fault pin. #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeter
reviewed
Nov 3, 2023
This pulls the fault pin low (active) shortly after the sequencer task first runs, and then sets it high (inactive) only once we get up to the IPC loop. Failures in the sequencer startup tend to cause panics, which will have the effect of holding the pin low as the task is repeatedly restarted. This also means we will be able to externally observe any other restart of the task.
cbiffle
force-pushed
the
gimlet-sequencer-fault
branch
from
c773c6d to
329643e
Compare
labbott
approved these changes
Nov 3, 2023
mkeeter
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls the fault pin low (active) shortly after the sequencer task first runs, and then sets it high (inactive) only once we get up to the IPC loop.
Failures in the sequencer startup tend to cause panics, which will have the effect of holding the pin low as the task is repeatedly restarted. This also means we will be able to externally observe any other restart of the task.