-
Notifications
You must be signed in to change notification settings - Fork 13
Add component for empty MiniTable #2811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Once we're happy with the approach, I'll roll it out to other MiniTable instances. |
I know @david-crespo likes components to be more declarative, but I wonder if the current mini table implementation leaves room for accidental differences to sneak in. I say that here because we could pass items to the mini table and let it handle the empty state within the component automatically. We're also going to have two versions with these webhook changes, one that is pretty much the same as it is now and one with integrated inputs. In this case would we keep the existing component and create a wrapper component that takes props directly instead? |
This adds an empty state for MiniTables. One hope is that this resolves (or at least mitigates) #2627.
The no-whitespace-diffs view is a bit easier to glance at: https://github.com/oxidecomputer/console/pull/2811/files?diff=split&w=1
Closes #2661