Radix dropdown -> Headless dropdown #2452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
headless-dropdown
branch
from
dd62709 to
fe32b9b
Compare
david-crespo
force-pushed
the
headless-dropdown
branch
from
fe32b9b to
4870bd8
Compare
david-crespo
force-pushed
the
headless-dropdown
branch
from
4870bd8 to
ac920b3
Compare
charliepark
approved these changes
Sep 17, 2024
|
Still need to fix this. Radix locks scroll when the dropdown is open to prevent this from happening. Headless has a 2024-09-17-dropdown-menu-z-bug.mp4 |
|
5c5cdd1 seems good: 2024-09-18-z-topBarPopover.mp4 |
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Sep 19, 2024
oxidecomputer/console@ce242e7...5561f28 * [5561f285](oxidecomputer/console@5561f285) oxidecomputer/console#2455 * [5640bf9f](oxidecomputer/console@5640bf9f) oxidecomputer/console#2454 * [e3d42459](oxidecomputer/console@e3d42459) oxidecomputer/console#2452 * [728f1eb9](oxidecomputer/console@728f1eb9) oxidecomputer/console#2451 * [a7cb26f9](oxidecomputer/console@a7cb26f9) fix type error due to bad xterm import * [7107b5b1](oxidecomputer/console@7107b5b1) remove unused xterm-addon-fit from package.json
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Sep 19, 2024
oxidecomputer/console@ce242e7...5561f28 * [5561f285](oxidecomputer/console@5561f285) oxidecomputer/console#2455 * [5640bf9f](oxidecomputer/console@5640bf9f) oxidecomputer/console#2454 * [e3d42459](oxidecomputer/console@e3d42459) oxidecomputer/console#2452 * [728f1eb9](oxidecomputer/console@728f1eb9) oxidecomputer/console#2451 * [a7cb26f9](oxidecomputer/console@a7cb26f9) fix type error due to bad xterm import * [7107b5b1](oxidecomputer/console@7107b5b1) remove unused xterm-addon-fit from package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Radix has given us a bit of trouble here and there and I'd prefer to be all-in on Headless. While working on #2450, decided to poke at converting our dropdown to use Headless. The goal is to keep the API of our wrapper component roughly the same to minimize the diff. Plus we cut the bundle size a tiny bit (384 kB to 376 kB gzipped). Can't drop
@radix-ui/react-focus-guardsyet because it's still used by the dialog lib.The four spots the dropdown menu is used are:
TopBarPicker(project/instance/vpc picker in header bar)