Skip to content

Add more baud rates. #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add more baud rates. #165

wants to merge 1 commit into from
+16 −2

Conversation

daym
Copy link
Collaborator

@daym daym commented May 8, 2025

Fixes #161.

@daym daym requested a review from luqmana May 8, 2025 19:47
@daym daym force-pushed the issue-161 branch 2 times, most recently from b67c2fb to 2c74a75 Compare May 8, 2025 19:51
luqmana
luqmana reviewed May 8, 2025
View reviewed changes
src/ondisk.rs Outdated
/// The variant meaning 230400 Baud only got added with Turin.
/// The variant meaning Hacky 3000000 Baud got added with one custom Milan bootloader build.
#[cfg_attr(feature = "serde", serde(rename = "230400 Baud"))]
#[cfg_attr(feature = "serde", serde(alias = "Hacky 3000000 Baud"))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're gonna make it a flag day type change, is it worth even keeping this alias? Might as well just update the custom milan configs and make em use the raw value:

{
	Unknown: {
		entry_id: "Byte",
		// AblSerialBaudRate
		tag: 0xAE46CEA4,
		// 3 MBaud (Milan Fast Spew)
		value: 9
	}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luqmana luqmana luqmana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ABL Baud Rate token values differ between versions
2 participants
@daym @luqmana