Remove direct token accessor functions. #164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daym
force-pushed
the
issue-121
branch
2 times, most recently
from
b195b37 to
00d873b
Compare
dancrossnyc
reviewed
May 8, 2025
src/tests.rs
Outdated
| let tokens = | ||
| apcb.tokens(0, BoardInstances::from_instance(0).unwrap()).unwrap(); | ||
| assert!(tokens.abl_serial_baud_rate().unwrap() == BaudRate::_4800Baud); | ||
| // let value = tokens.get(TokenEntryId::from_u16(entry_id).unwrap(), ByteToken::AblSerialBaudRate as u32).unwrap(); |
dancrossnyc
reviewed
May 8, 2025
src/tests.rs
Outdated
| assert!(tokens.abl_serial_baud_rate().unwrap() == BaudRate::_4800Baud); | ||
| tokens.set_abl_serial_baud_rate(BaudRate::_9600Baud).unwrap(); | ||
| assert!(tokens.abl_serial_baud_rate().unwrap() == BaudRate::_9600Baud); | ||
| //let value = tokens.get(TokenEntryId::from_u16(entry_id).unwrap(), ByteToken::AblSerialBaudRate as u32).unwrap(); |
There was a problem hiding this comment.
Sure. I just wanted to show to that the interface isn't the same at all now.
Also, the interface type safety is lower now, except for the serde interface.
dancrossnyc
approved these changes
May 8, 2025
daym
force-pushed
the
issue-121
branch
3 times, most recently
from
fbb5aad to
4279f62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121.