Open
Conversation
Bilb
force-pushed
the
feat/various-retrieve-additions
branch
6 times, most recently
from
405ef13 to
6242dfd
Compare
Bilb
force-pushed
the
feat/various-retrieve-additions
branch
from
6242dfd to
5577991
Compare
jagerman
reviewed
Apr 9, 2025
| "WHERE owner = ? AND namespace = ? ORDER BY id LIMIT ?"); | ||
| "SELECT hash, namespace, timestamp, expiry, data FROM messages " | ||
| "WHERE owner = ? AND namespace = ? {} ORDER BY id {} LIMIT ?"_format( | ||
| last_id ? "AND id > ?" : "", reverse_direction ? "DESC" : "ASC")); |
Member
There was a problem hiding this comment.
I'm not 100% sure of this, but is this working properly if both last_id and reverse_direction are true? I think when both are specified the AND id > ? should get flipped to AND id < ?.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.