Skip to content

test(allocator): fix compile fail doctest#21400

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/04-13-test_allocator_fix_compile_fail_doctest
Apr 13, 2026
Merged

test(allocator): fix compile fail doctest#21400
graphite-app[bot] merged 1 commit intomainfrom
om/04-13-test_allocator_fix_compile_fail_doctest

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 13, 2026

Fix doctest that checks that Arena is not Sync. This was previously failing to compile as expected, but not for the right reasons! The import path was wrong.

Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 13, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-allocator Area - Allocator C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Apr 13, 2026
@overlookmotel overlookmotel self-assigned this Apr 13, 2026
@overlookmotel overlookmotel marked this pull request as ready for review April 13, 2026 18:24
Copilot AI review requested due to automatic review settings April 13, 2026 18:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a compile-fail doctest intended to verify that Arena is not Sync, by correcting the import path so the doctest fails for the intended reason (trait bound) rather than an unresolved import.

Changes:

  • Update the doctest import to use oxc_allocator::arena::Arena (feature-gated public module for doctests/tests).

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 13, 2026

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/04-13-test_allocator_fix_compile_fail_doctest (9fb2d9c) with main (2e144c2)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (9fb2d9c) during the generation of this report, so 2e144c2 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Apr 13, 2026

Merge activity

Fix doctest that checks that `Arena` is not `Sync`. This was previously failing to compile as expected, but not for the right reasons! The import path was wrong.
@graphite-app graphite-app bot force-pushed the om/04-13-docs_allocator_remove_references_to_bump_from_comments branch from 2e0a1ae to 922cbee Compare April 13, 2026 18:34
@graphite-app graphite-app bot force-pushed the om/04-13-test_allocator_fix_compile_fail_doctest branch from 813c4ba to 9fb2d9c Compare April 13, 2026 18:35
Base automatically changed from om/04-13-docs_allocator_remove_references_to_bump_from_comments to main April 13, 2026 18:40
@graphite-app graphite-app bot merged commit 9fb2d9c into main Apr 13, 2026
36 checks passed
@graphite-app graphite-app bot deleted the om/04-13-test_allocator_fix_compile_fail_doctest branch April 13, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-allocator Area - Allocator C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants