perf(linter/vitest): speed up checking a call if it is a valid vitest call #11384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The valid vitest calls are generated according to combination rules, see vitest-dev/eslint-plugin-vitest#276 so that we can simplify it by checking the possible combination rather than checking all possible methods, which can avoid an expensive action
String::join
.The reason why I did this is that I found the biome has a similar checking algorithm, and it also needed to be used in the formatter. So I am looking at our implementation to check whether we can use the same method in both the linter and the formatter in our codebase. So far, I have found that both Biome and Oxlint have a little difference in the check. I don't know what makes the difference, and I won't dig into it for now. I will revisit when most of the formatting work is done.