Skip to content

fix(estree): Serialize adjusted span for TSTypePredicate.typeAnnotation #10707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

leaysgur
Copy link
Member

@leaysgur leaysgur commented Apr 30, 2025

Part of #9705

  • Rust
  • Raw deser
  • Comments

NOTE: I tried to deal with this during serialization, but this may be a parser issue? I'll do some research... #10711

Copy link
Contributor

graphite-app bot commented Apr 30, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Apr 30, 2025
Copy link

codspeed-hq bot commented Apr 30, 2025

CodSpeed Instrumentation Performance Report

Merging #10707 will not alter performance

Comparing fix/typepredicate_span (3da6db6) with main (7d8efd8)

Summary

✅ 33 untouched benchmarks
🆕 3 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3.1 s N/A

@leaysgur leaysgur changed the title fix(estree): Adjust span for TSTypePredicate.typeAnnotation fix(estree): Serialize adjusted span for TSTypePredicate.typeAnnotation Apr 30, 2025
@leaysgur
Copy link
Member Author

OK, IMO, it is more appropriate to handle this in the parser, so close this.

@leaysgur leaysgur closed this Apr 30, 2025
@leaysgur leaysgur deleted the fix/typepredicate_span branch April 30, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant