Skip to content

Conversation

@saw-jan
Copy link
Member

@saw-jan saw-jan commented Oct 1, 2024

Description

  • compare the file-id pattern not the actual id in PROPFIND/REPORT response
    • because we were doing the same PROPFIND request to get the file-id and compare with similar PROPFIND request
  • step changes:
-Then the "REPORT/PROPFIND" response should contain a space/mountpoint "<name>" with these key and value pairs:
-Then the "REPORT/PROPFIND" response to user "<user>" should contain a space/mountpoint "<name>" with these key and value pairs:
+Then as user "<user>" the REPORT/PROPFIND response should contain a space/resource "<name>" with these key and value pairs:
  • added jsonSchemaRegexToPureRegex to convert existing json schema regex to php regex
  • moved sendScenarioLineReferencesInXRequestId to HttpRequestHelper
  • fix X-Request-Id header tests to make it pass when SEND_SCENARIO_LINE_REFERENCES is not set
  • added %request_id_pattern% and getXRequestIdRegex

Related Issue

How Has This Been Tested?

  • test environment:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan added the QA:team label Oct 1, 2024
@saw-jan saw-jan self-assigned this Oct 1, 2024
@saw-jan saw-jan force-pushed the tests/fix-shares-propfind branch from 1b2e070 to 2d281ef Compare October 1, 2024 12:24
@saw-jan saw-jan force-pushed the tests/fix-shares-propfind branch 3 times, most recently from c79c13b to b8b345c Compare October 2, 2024 07:09
@saw-jan saw-jan marked this pull request as ready for review October 2, 2024 07:09
@saw-jan saw-jan force-pushed the tests/fix-shares-propfind branch from b8b345c to 69e6d38 Compare October 2, 2024 07:48
@saw-jan saw-jan force-pushed the tests/fix-shares-propfind branch from 69e6d38 to ca82ac0 Compare October 2, 2024 07:52
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2024

Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan merged commit e6902ce into master Oct 2, 2024
4 checks passed
@saw-jan saw-jan deleted the tests/fix-shares-propfind branch October 2, 2024 08:46
ownclouders pushed a commit that referenced this pull request Oct 2, 2024
[tests-only][full-ci] fix shares propfind tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants