[fix/ocis-sharing-names] Update sharing-related terms for oCIS #1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add extension to abstract name + icon differences between OC10/oCIS away for sharedWithMe actions + sections - replace icon and labels with calls to new extension - OCShare+Interactions: replace icon and labels with calls to new extension - ClientSharedWithMeViewController: replace icon and labels with calls to new extension
felix-schwarz
force-pushed
the
fix/ocis-sharing-names
branch
from
1336ca3 to
9805cb3
Compare
DeepDiver1975
approved these changes
Oct 7, 2025
…haring-roles-icons merged in
Contributor
|
About this PR:
@dj4oC please check the screenshots above to assure they accomplish the customer expectations. From QA, nothing else to say. Feel free to move forward. |
OK
|
- CollaborateAction: do not show for spaces (where MembersSpaceAction offers the same functionality) to avoid duplication - ShareViewController: change labels according to feedback from #1504 - SharingViewController: place "Copy Private Link" into its own section (following feedback from #1504) and call it "Permanent Link" when connected to oCIS servers
Contributor
Author
|
@dj4oC Danke für das Feedback.
Erledigt.
Erledigt.
Diese Beschreibungen kommen vom Server und enthalten z.T. eine Dopplung: "Ansehen, herunterladen, bearbeiten und anzeigen…"
Yes.
Done. Sidenote on consistency: when entering this link in a browser, a message "Auflösen des privaten Links…" appears: 
Done. I detached the entry into its own section: 
This is indeed a duplication. Fixed that, too. 
Fixed. (see second-last screenshot).
Fixed. (see last screenshot) |
Contributor
Author
|
@dj4oC Please have a look at the new screenshots with the changes included and approve the PR in case everything's how it should be now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
https://github.com/owncloud/enterprise/issues/7320
Screenshots (if appropriate):
"Shared with me" connected to an oCIS server
"Create Link" and "Edit Link" views now localized in German
Icons for all sharing roles
(user name and avatar masked for privacy after taking the screenshots)
Spaces Menus fully localized
Types of changes