fix: add Windows specific characters to config value syntax #3430
+3,810
−3,734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #3429 - @skvoboo-gh tested this on Windows. |
theseion
requested changes
Aug 1, 2025
Co-authored-by: Max Leske <[email protected]>
theseion
previously approved these changes
Aug 1, 2025
This reverts commit 28bc3a9.
|
|
Okay, I found the problem and fixed it. Recent changes:
|
theseion
requested changes
Aug 3, 2025
theseion
approved these changes
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This PR fixes a bug: if the host is a Windows based server, and admin wants to set any path where the directory name contains space (and the separator is the blackslash), then parser throws an error.
These characters have been added:
\(backslash) (it's escaped, so this is it:\\(and)(parenthesis) (these are also escaped)why
The problem is described in #3429.
references
#3429