Fix memory/socket leak in UniqueId::ethernetMacAddress()
#3392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't jump over `close()`/`free()`
|
|
Hi @amezin, nice catch, many thanks for this PR! |
airween
approved these changes
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Don't jump over
close()/free()calls. Release the resources correctly in all code paths.why
Currently, there are memory, and, in case of Linux, socket leaks.
goto endjumps over the calls that are supposed to release the memory/close the socket.references
Initially discovered this on v2 - #3391 - but turns out the code is the same on v3 too.