Fix OpenBSD build #1852
Closed
Fix OpenBSD build #1852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorhora
added
RIP - Type - Feature
enhancement
RIP - libmodsecurity
3.x
|
Maybe we should consider using glob.h by default on all platforms as a matter of best practice due to security concerns with wordexp. That being said, according to the docs, glob.h has "No tilde expansion or parameter substitution is done; if you want these, use wordexp(3)." GLOB_TILDE flag could be used for tilde expansion, but as this would require further changes I refrained from doing this at the moment. |
|
Wondering if something like: Would be a valid test scenario to prove that expandEnv() is also functionally correct when using glob. Thoughts? |
|
Merged! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBSD build was breaking due to the lack of wordexp.h. Patch fixes the build by using glob.h when building on OpenBSD. Should fix #1841.