Adds support for ctl:requestBodyProcessor=URLENCODED #1807
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorhora
added
MEDIUM Priority
RIP - libmodsecurity
libmodsec - missing features
3.x
victorhora
commented
Jul 16, 2018
| @@ -27,7 +27,7 @@ namespace ctl { | |||
|
|
|||
| bool RequestBodyProcessorURLENCODED::evaluate(Rule *rule, | |||
| Transaction *transaction) { | |||
| transaction->m_requestBodyProcessor = Transaction::WWWFormUrlEncoded; | |||
| transaction->m_requestBodyType = Transaction::WWWFormUrlEncoded; | |||
There was a problem hiding this comment.
Hey @zimmerle, although the configuration was being accepted by the parser, there was a problem with the pull request as the condition to actually extract the arguments was not being satisfied due to the usage of the m_requestBodyType as opposed to m_requestBodyProcessor variable which is used for the XML and JSON body processors. My bad 😋
NixM0nk3y
added a commit
to NixM0nk3y/ModSecurity
that referenced
this pull request
Aug 14, 2018
victorhora
added a commit
that referenced
this pull request
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for URLENCODED body processor as defined at WWWFormUrlEncoded. Should fix #1797