Actually fix setvar parsing of quoted data #1775
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorhora
added
MEDIUM Priority
enhancement
RIP - libmodsecurity
3.x
|
@victorhora @zimmerle going to check this one in a few. Will provide an update here. |
|
@victorhora @zimmerle this PR fixes the issue (I've been building libmodsecurity with |
|
@victorhora @zimmerle it works fine without rebuilding parser, so I think we're good here. Thanks guys! |
|
normalized bison version and re-submitted to tests. at: v3/dev/pull_1775 |
|
Merged! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper fix for #1733 on top of #1759