Skip to content

Add missing escapeSeqDecode, urlEncode and trimLeft/Right tfns to parser #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add missing escapeSeqDecode, urlEncode and trimLeft/Right tfns to parser #1752

wants to merge 1 commit into from

Conversation

victorhora
Copy link
Contributor

Transformations were implemented and confirmed working but were missing statements in the parser. Should avoid errors messages like this one if one tries to use urlEncode, trimLeft, trimRight or escapeSeqDecode

nginx: [emerg] "modsecurity_rules_file" directive Rules error. File: modsecurity.conf. Line: 615. Column: 107. Expecting an action, got:  t:escapeSeqDecode" in nginx.conf:26

@victorhora victorhora added this to the v3.0.3 milestone Apr 23, 2018
@victorhora victorhora requested a review from zimmerle April 23, 2018 20:24
@zimmerle
Copy link
Contributor

Merged! thanks!

@zimmerle zimmerle closed this Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimmerle zimmerle Awaiting requested review from zimmerle

Assignees

@zimmerle zimmerle

@victorhora victorhora

Labels
3.x Related to ModSecurity version 3.x RIP - libmodsec - missing transformation RIP - libmodsecurity
Projects
None yet
Milestone
v3.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@victorhora @zimmerle