-
Notifications
You must be signed in to change notification settings - Fork 4
#261: Implementation of Header Component #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SaqAsh
wants to merge
13
commits into
main
Choose a base branch
from
feature/header-component
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+123
−43
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5b09c2e
finish up code cleanup and make sure that all styling is close to fig…
SaqAsh 0fa14d9
type theme appropriately instead of settling for any
SaqAsh 62b5ec4
fix styling and add comments for fonts
SaqAsh 376f887
add some permuations of testing and reduce the threshold constants
SaqAsh afe4e16
final cleanup before pr, remove uneccesary styling
SaqAsh 8e7cc5e
fix logic flaw
SaqAsh 296af83
add minor spacing
SaqAsh b123752
remove tacky v
SaqAsh cc05e97
fix horizontal scrolling issue with css
SaqAsh 69c2ec6
address preceeding text spacing comment from pr
SaqAsh 174922f
exporting component props
SaqAsh 60dab2d
rename the constant to fit the naming standards better and add commen…
SaqAsh 0f1f851
Merge branch 'main' into feature/header-component
SaqAsh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was not too happy with this implementation, I have refactored this into something that appropriately implements this to spec in another branch