Decrement pendingRequests counter when Bun.serve responds with HTTP 413#18833
Open
CMTegner wants to merge 1 commit intooven-sh:mainfrom
Open
Decrement pendingRequests counter when Bun.serve responds with HTTP 413#18833CMTegner wants to merge 1 commit intooven-sh:mainfrom
pendingRequests counter when Bun.serve responds with HTTP 413#18833CMTegner wants to merge 1 commit intooven-sh:mainfrom
Conversation
Author
|
I'm not sure what the correct procedure is to request a review, so I'll just take a shot in the dark and ping @Jarred-Sumner |
CMTegner
commented
May 5, 2025
Comment on lines
+6804
to
6805
| this.pending_requests -= 1; | ||
| this.finalize(); |
Author
There was a problem hiding this comment.
It looks like finalize() is only used in this conditional, so the statement to decrement pending_requests could possibly be moved if that's preferable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change decrements the
Server#pendingRequestscounter when a request exceeds themaxRequestBodySizevalue passed toBun.serve().How did you verify your code works?
Added an additional assertion to the existing HTTP 413 test, ensuring that
server.pendingRequestsreturns to 0.bun-debug test test-file-name.test)