transpiler: fix crash with malformed enums (#16084)

oven-sh · Dec 31, 2024 · 37e7f5b · 37e7f5b
1 parent babd8b6
commit 37e7f5b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/js_parser.zig b/src/js_parser.zig
@@ -11917,6 +11917,8 @@ fn NewParser_(
                     needs_symbol = true;
                 } else {
                     try p.lexer.expect(.t_identifier);
+                    // error early, name is still `undefined`
+                    return error.SyntaxError;
                 }
                 try p.lexer.next();
 

diff --git a/test/bundler/transpiler/transpiler.test.js b/test/bundler/transpiler/transpiler.test.js
@@ -315,6 +315,13 @@ describe("Bun.Transpiler", () => {
       exp("f<{}>()\nfunction f<T>() {}", "let f = function() {\n};\nf()");
     });
 
+    it("malformed enums", () => {
+      const err = ts.expectParseError;
+
+      err("enum Foo { [2]: 'hi' }", 'Expected identifier but found "["');
+      err("enum [] { a }", 'Expected identifier but found "["');
+    });
+
     // TODO: fix all the cases that report generic "Parse error"
     it("types", () => {
       const exp = ts.expectPrinted_;