Skip to content

Commit

Permalink
mv syntaxCheck to separate class, add publish to allure
Browse files Browse the repository at this point in the history
  • Loading branch information
ovcharenko-di committed Jan 17, 2025
1 parent 89e104f commit 161a4f5
Show file tree
Hide file tree
Showing 6 changed files with 135 additions and 70 deletions.
5 changes: 3 additions & 2 deletions resources/globalConfiguration.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
},
"syntaxCheck": {
"groupErrorsByMetadata": true,
"pathToJUnitReport": "./build/out/jUnit/syntax.xml",
"exceptionFile": "./tools/syntax-check-exception-file.txt",
"checkModes": [
"-ThinClient",
Expand All @@ -79,7 +78,9 @@
"-CheckUseSynchronousCalls",
"-DistributiveModules"
],
"vrunnerSettings": "./tools/vrunner.json"
"vrunnerSettings": "./tools/vrunner.json",
"publishToAllureReport": false,
"publishToJUnitReport": true
},
"smoke": {
"vrunnerSettings": "./tools/vrunner.json",
Expand Down
10 changes: 7 additions & 3 deletions resources/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -378,9 +378,13 @@
"type" : "boolean",
"description" : "Группировать выявленные ошибки по объектам метаданных.\n По умолчанию включено.\n "
},
"pathToJUnitReport" : {
"type" : "string",
"description" : "Путь к файлу отчета jUnit\n По умолчанию содержит значение \"./build/out/jUnit/syntax.xml\"\n "
"publishToAllureReport" : {
"type" : "boolean",
"description" : "Выполнять публикацию результатов в отчет Allure.\n По умолчанию выключено.\n "
},
"publishToJUnitReport" : {
"type" : "boolean",
"description" : "Выполнять публикацию результатов в отчет JUnit.\n По умолчанию включено.\n "
},
"vrunnerSettings" : {
"type" : "string",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@ import com.fasterxml.jackson.annotation.JsonPropertyDescription
@JsonIgnoreProperties(ignoreUnknown = true)
class SyntaxCheckOptions implements Serializable {

@JsonPropertyDescription("""Путь к файлу отчета jUnit
По умолчанию содержит значение "./build/out/jUnit/syntax.xml"
""")
String pathToJUnitReport = "./build/out/jUnit/syntax.xml"

@JsonPropertyDescription("""Группировать выявленные ошибки по объектам метаданных.
По умолчанию включено.
""")
Expand All @@ -31,14 +26,25 @@ class SyntaxCheckOptions implements Serializable {
""")
String vrunnerSettings = "./tools/vrunner.json"

@JsonPropertyDescription("""Выполнять публикацию результатов в отчет Allure.
По умолчанию выключено.
""")
boolean publishToAllureReport

@JsonPropertyDescription("""Выполнять публикацию результатов в отчет JUnit.
По умолчанию включено.
""")
boolean publishToJUnitReport

@Override
@NonCPS
String toString() {
return "SyntaxCheckOptions{" +
"pathToJUnitReport='" + pathToJUnitReport + '\'' +
", groupErrorsByMetadata=" + groupErrorsByMetadata +
", checkModes=" + checkModes +
", vrunnerSettings=" + vrunnerSettings +
'}';
", publishToAllureReport=" + publishToAllureReport +
", publishToJUnitReport=" + publishToJUnitReport +
'}'
}
}
96 changes: 96 additions & 0 deletions src/ru/pulsar/jenkins/library/steps/SyntaxCheck.groovy
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
package ru.pulsar.jenkins.library.steps

import hudson.FilePath
import ru.pulsar.jenkins.library.IStepExecutor
import ru.pulsar.jenkins.library.configuration.JobConfiguration
import ru.pulsar.jenkins.library.ioc.ContextRegistry
import ru.pulsar.jenkins.library.utils.FileUtils
import ru.pulsar.jenkins.library.utils.Logger
import ru.pulsar.jenkins.library.utils.VRunner

class SyntaxCheck {

public static final String ALLURE_STASH = 'syntax-check-allure'

private final JobConfiguration config

SyntaxCheck(JobConfiguration config) {
this.config = config
}

def run() {
IStepExecutor steps = ContextRegistry.getContext().getStepExecutor()

Logger.printLocation()

if (!config.stageFlags.syntaxCheck) {
Logger.println("Syntax-check step is disabled")
return
}

def env = steps.env()

def options = config.syntaxCheckOptions

List<String> logosConfig = ["LOGOS_CONFIG=$config.logosConfig"]
steps.withEnv(logosConfig) {
steps.installLocalDependencies()

String junitReport = "build/out/jUnit/syntax-check/syntax-check.xml"
FilePath pathToJUnitReport = FileUtils.getFilePath("$env.WORKSPACE/$junitReport")
String junitReportDir = FileUtils.getLocalPath(pathToJUnitReport.getParent())

String allureReport = "build/out/allure/syntax-check/allure.xml"
FilePath pathToAllureReport = FileUtils.getFilePath("$env.WORKSPACE/$allureReport")
String allureReportDir = FileUtils.getLocalPath(pathToAllureReport.getParent())

String vrunnerPath = VRunner.getVRunnerPath()
String command = "$vrunnerPath syntax-check --ibconnection \"/F./build/ib\""

// Временно убрал передачу параметра.
// См. https://github.com/vanessa-opensource/vanessa-runner/issues/361
// command += " --workspace $env.WORKSPACE"

if (options.groupErrorsByMetadata) {
command += ' --groupbymetadata'
}

if (options.publishToJUnitReport) {
steps.createDir(junitReportDir)
command += " --junitpath $pathToJUnitReport"
}

if (options.publishToAllureReport) {
steps.createDir(allureReportDir)
command += " --allure-results2 $allureReportDir"
}

FilePath vrunnerSettings = FileUtils.getFilePath("$env.WORKSPACE/$options.vrunnerSettings")
if (vrunnerSettings.exists()) {
command += " --settings $vrunnerSettings"
}

if (!options.exceptionFile.empty && steps.fileExists(options.exceptionFile)) {
command += " --exception-file $options.exceptionFile"
}

if (options.checkModes.length > 0) {
def checkModes = options.checkModes.join(" ")
command += " --mode $checkModes"
}

// Запуск синтакс-проверки
VRunner.exec(command, true)

if (options.publishToAllureReport) {
steps.stash(ALLURE_STASH, "$allureReportDir/**", true)
steps.archiveArtifacts("$allureReportDir/**")
}

if (options.publishToJUnitReport) {
steps.junit("$junitReportDir/*.xml", true)
steps.archiveArtifacts("$junitReportDir/**")
}
}
}
}
16 changes: 13 additions & 3 deletions vars/pipeline1C.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -248,9 +248,19 @@ void call() {
beforeAgent true
expression { config.stageFlags.syntaxCheck }
}
steps {
timeout(time: config.timeoutOptions.syntaxCheck, unit: TimeUnit.MINUTES) {
syntaxCheck config
stages {
stage('Распаковка ИБ') {
steps {
unzipInfobase()
}
}

stage('Выполнение синтаксического контроля') {
steps {
timeout(time: config.timeoutOptions.syntaxCheck, unit: TimeUnit.MINUTES) {
syntaxCheck config
}
}
}
}
}
Expand Down
58 changes: 3 additions & 55 deletions vars/syntaxCheck.groovy
Original file line number Diff line number Diff line change
@@ -1,64 +1,12 @@
import hudson.FilePath
import ru.pulsar.jenkins.library.configuration.JobConfiguration
import ru.pulsar.jenkins.library.ioc.ContextRegistry
import ru.pulsar.jenkins.library.utils.FileUtils
import ru.pulsar.jenkins.library.utils.VRunner
import ru.pulsar.jenkins.library.steps.SyntaxCheck

def call(JobConfiguration config) {

ContextRegistry.registerDefaultContext(this)

// TODO: Вынести в отдельный класс по аналогии с SonarScanner
def syntaxCheck = new SyntaxCheck(config)
syntaxCheck.run()

printLocation()

if (!config.stageFlags.syntaxCheck) {
echo("Syntax-check step is disabled")
return
}

def options = config.syntaxCheckOptions

installLocalDependencies()

unzipInfobase()

FilePath pathToJUnitReport = FileUtils.getFilePath("$env.WORKSPACE/$options.pathToJUnitReport")

String outPath = pathToJUnitReport.getParent()
createDir(outPath)

String vrunnerPath = VRunner.getVRunnerPath();
String command = "$vrunnerPath syntax-check --ibconnection \"/F./build/ib\""

// Временно убрал передачу параметра.
// См. https://github.com/vanessa-opensource/vanessa-runner/issues/361
// command += " --workspace $env.WORKSPACE"

if (options.groupErrorsByMetadata) {
command += ' --groupbymetadata'
}

command += " --junitpath $pathToJUnitReport";

FilePath vrunnerSettings = FileUtils.getFilePath("$env.WORKSPACE/$options.vrunnerSettings")
if (vrunnerSettings.exists()) {
command += " --settings $vrunnerSettings";
}

if (!options.exceptionFile.empty && fileExists(options.exceptionFile)) {
command += " --exception-file $options.exceptionFile"
}

if (options.checkModes.length > 0) {
def checkModes = options.checkModes.join(" ")
command += " --mode $checkModes"
}

// Запуск синтакс-проверки
VRunner.exec(command, true)

junit allowEmptyResults: true, testResults: FileUtils.getLocalPath(pathToJUnitReport)

archiveArtifacts FileUtils.getLocalPath(pathToJUnitReport)
}

0 comments on commit 161a4f5

Please sign in to comment.