feat(controller): Add flag to change the default syncPeriod #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvdhart
force-pushed
the
feat/controller/add-sync-period-flag
branch
from
8fbe8fb to
5925e31
Compare
jfbus
approved these changes
Feb 6, 2025
jfbus
requested changes
Feb 6, 2025
jfbus
reviewed
Feb 7, 2025
| @@ -86,6 +88,7 @@ func main() { | |||
| LeaseDuration: &leaseDuration, | |||
| RenewDeadline: &renewDeadline, | |||
| RetryPeriod: &retryPeriod, | |||
| SyncPeriod: &syncPeriod, | |||
There was a problem hiding this comment.
Shouldn't it be
Cache: cache.Options{
SyncPeriod: &syncPeriod
},
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feature
What this PR does / why we need it:
Add flag to controller to change the default syncPeriod (aka the minimum time between reconciles when no resource has been changed).
Fixes #374
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: