feat(securitygroups): Add option to delete default outbound rule #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outscale-hmi
requested changes
Sep 4, 2024
config/crd/bases/infrastructure.cluster.x-k8s.io_oscclusters.yaml
Outdated
Show resolved
Hide resolved
| @@ -342,6 +343,14 @@ func reconcileSecurityGroup(ctx context.Context, clusterScope *scope.ClusterScop | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| if deleteDefaultOutboundRule { | |||
There was a problem hiding this comment.
Can you add a unit test ?
gvdhart
force-pushed
the
feat/securitygroups/delete-default-outbound-rule
branch
from
4ecc679 to
24431d1
Compare
|
Will add this here instead: #373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option in security group spec to remove default outbound rule that allows all outbound traffic