Prep for notifying speakers: feedback form and (radical) visting page #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcwalk
changed the title
garrying
reviewed
Jul 17, 2019
| @@ -0,0 +1,82 @@ | |||
| --- | |||
There was a problem hiding this comment.
@dcwalk should the filename be session-confirmation? Looking at the URL in https://github.com/ournetworks/2019/pull/66/files#diff-05c96faad7724d9a3e068b6976a623ddR14
garrying
reviewed
Jul 17, 2019
| @@ -45,6 +45,10 @@ if (window.location.search == '?donation=confirmed') { | |||
| formSubmitCallback('Thanks for your support!'); | |||
| } | |||
|
|
|||
| if (window.location.search == '?update=confirmed') { | |||
| formSubmitCallback('Successfully confirmed your session!'); | |||
There was a problem hiding this comment.
Added a brief announcement banner message
garrying
reviewed
Jul 17, 2019
garrying
reviewed
Jul 17, 2019
garrying
reviewed
Jul 17, 2019
garrying
reviewed
Jul 17, 2019
garrying
reviewed
Jul 17, 2019
garrying
reviewed
Jul 17, 2019
garrying
reviewed
Jul 17, 2019
garrying
reviewed
Jul 17, 2019
garrying
reviewed
Jul 17, 2019
| <p>Please confirm you preferred pronunciation and pronouns as presenter(s):</p> | ||
| <div class="flex"> | ||
| <div class="w-33"> | ||
| <label class="fw-bold" for="presenters">Presenter:</label> |
There was a problem hiding this comment.
Suggested change
| <label class="fw-bold" for="presenters">Presenter:</label> | |
| <label class="fw-bold" for="presenters">Presenter name:</label> |
More explicit field label
dcwalk
changed the title
Co-Authored-By: Garry Ing <[email protected]>
|
I think the reason the check is failing is the bug #113, I'm going to merge because this is v/ time sensitive (bad practices!) and we can follow up with deploy issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will address ournetworks/2019#49!