Repository navigation
Stop the update in progress with Esc - #821
Open
Leonhardmaster2 wants to merge 2 commits into
Open
Leonhardmaster2 wants to merge 2 commits into
Leonhardmaster2 wants to merge 2 commits into
Conversation
Esc in the main window, when no widget uses it (a rename field still cancels with it), stops the background update without waiting for the node being computed: that node ends in the background and nothing after it is computed. What is left is held and taken along by the next update, so the next edit brings the whole graph up to date again. The progress bar is cleared and the status bar says the update stopped.
Member
|
One small fix needed: when the update is interrupted, the progress bar is not update. Writing this makes me think that the graph model is then in an "intermediate" state, this should be signaled to the user (with a red label "graph need update" somewhere). It's notified but pretty easy to miss. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third small polish PR for the background compute: Esc stops the update that's running.
A real "stop" button can come with the graph editor UI rework, this just puts the worker side in place plus a shortcut.
Built and tested on Windows.