Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General performance and memory usage improvements #316

Merged
merged 31 commits into from
Jan 21, 2024

Conversation

ammarasyad
Copy link
Contributor

Continuing on the last PR by Reco1l, I decided to incorporate some of his changes to the current osu!droid codebase, with some of my own changes. As this will bring a large change, this will require extensive testing to ensure stability. Report any performance regressions, bugs, or unexpected changes in gameplay.

This PR is mostly a work-in-progress, as I iron out bugs, edge cases, and potential compatibility issues that may arise from the changes. In the meantime, if you wish to help and is able to build osu!droid, please test from my branch. Any input is appreciated.

@ammarasyad ammarasyad marked this pull request as ready for review January 11, 2024 11:59
Copy link
Member

@Rian8337 Rian8337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. I have not tested multiplayer yet, since there appears to be multiplayer changes. However, I'm not sure if the change towards speed modify bar (having to check the box first before dragging the slider) is intended, but it brings parity with force difficulty statistics, so I will leave it be.

src/com/edlplan/ui/fragment/InGameSettingMenu.kt Outdated Show resolved Hide resolved
@ammarasyad
Copy link
Contributor Author

Mostly looks good. I have not tested multiplayer yet, since there appears to be multiplayer changes. However, I'm not sure if the change towards speed modify bar (having to check the box first before dragging the slider) is intended, but it brings parity with force difficulty statistics, so I will leave it be.

It is intended. I didn't find the current behavior in release intuitive, so I changed it myself.

@Rian8337 Rian8337 merged commit c7e4076 into osudroid:master Jan 21, 2024
3 checks passed
@ammarasyad ammarasyad deleted the improvements branch February 10, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants