-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General performance and memory usage improvements #316
Conversation
…n rewrite) without singleton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good. I have not tested multiplayer yet, since there appears to be multiplayer changes. However, I'm not sure if the change towards speed modify bar (having to check the box first before dragging the slider) is intended, but it brings parity with force difficulty statistics, so I will leave it be.
It is intended. I didn't find the current behavior in release intuitive, so I changed it myself. |
Continuing on the last PR by Reco1l, I decided to incorporate some of his changes to the current osu!droid codebase, with some of my own changes. As this will bring a large change, this will require extensive testing to ensure stability. Report any performance regressions, bugs, or unexpected changes in gameplay.
This PR is mostly a work-in-progress, as I iron out bugs, edge cases, and potential compatibility issues that may arise from the changes. In the meantime, if you wish to help and is able to build osu!droid, please test from my branch. Any input is appreciated.