Skip to content

Commit

Permalink
Fix slider head late hit not considering cursor tracking state for ti…
Browse files Browse the repository at this point in the history
…ck judgement
  • Loading branch information
Rian8337 committed Nov 16, 2024
1 parent 806d309 commit fa27b58
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/ru/nsu/ccfit/zuev/osu/game/GameplaySlider.java
Original file line number Diff line number Diff line change
Expand Up @@ -906,13 +906,16 @@ private void onSliderHeadHit(double hitOffset) {

float distanceTrackingThresholdSquared = getTrackingDistanceThresholdSquared(true);

// Check whether the cursor is within the follow area.
boolean isTracking = isCursorInFollowArea(ballPos, true);

double currentTime = getGameplayPassedTimeMilliseconds();
boolean allTicksInRange = false;

var nestedObjects = beatmapSlider.getNestedHitObjects();

// Replays force their hit results per nested object, so we do not need to check for tracking here.
if (replayObjectData == null) {
if (isTracking && replayObjectData == null) {
allTicksInRange = true;

// Do not judge the slider end as it will be judged in onSpanFinish.
Expand Down

0 comments on commit fa27b58

Please sign in to comment.