Merge pull request #251 from reco1I/fragment

Fix potential InstantiationException at DownloadingFragment
osudroid · Jun 12, 2023 · 09c0bd9 · 09c0bd9
2 parents d3ebf1b + 568658f
commit 09c0bd9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/com/reco1l/legacy/ui/ChimuWebView.java b/src/com/reco1l/legacy/ui/ChimuWebView.java
@@ -108,7 +108,8 @@ public void onDownloadRequested(String url, String filename, String mimeType, lo
 
                 Downloader downloader = new Downloader(file, url);
 
-                mFragment = new DownloadingFragment(downloader, () -> {
+                mFragment = new DownloadingFragment();
+                mFragment.setDownloader(downloader, () -> {
 
                     mFragment.getText().setVisibility(View.VISIBLE);
                     mFragment.getText().setText(R.string.chimu_connecting);
@@ -120,7 +121,6 @@ public void onDownloadRequested(String url, String filename, String mimeType, lo
 
                     mFragment.getButton().setOnClickListener(v -> downloader.cancel());
                 });
-
                 mFragment.show();
             }
 

diff --git a/src/com/reco1l/legacy/ui/DownloadingFragment.java b/src/com/reco1l/legacy/ui/DownloadingFragment.java
@@ -13,16 +13,16 @@
 public class DownloadingFragment extends LoadingFragment
 {
 
-    private final Downloader mDownloader;
-    private final Runnable mAwaitCall;
+    private Downloader mDownloader;
+    private Runnable mAwaitCall;
 
     private Button mButton;
     private TextView mText;
     private CircularProgressIndicator mProgressBar;
 
     //----------------------------------------------------------------------------------------------------------------//
 
-    public DownloadingFragment(Downloader downloader, Runnable await)
+    public void setDownloader(Downloader downloader, Runnable await)
     {
         mAwaitCall = await;
         mDownloader = downloader;