RTC: Fix missing CRLF for SSRC group in SDP#4640
Open
thinker132203 wants to merge 1 commit intoossrs:developfrom
Open
RTC: Fix missing CRLF for SSRC group in SDP#4640thinker132203 wants to merge 1 commit intoossrs:developfrom
thinker132203 wants to merge 1 commit intoossrs:developfrom
Conversation
duiniuluantanqin
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello SRS team,
During my recent experimental development to support downlink RTX/FEC (which requires negotiating a=ssrc-group:FID/FEC to players), I found a formatting bug in the SDP generation logic.
In trunk/src/protocol/srs_protocol_sdp.cpp, the SrsSSRCGroup::encode function lacks a trailing kCRLF.
If ssrc_groups_ is not empty during downlink SDP generation, it will generate concatenated SDP lines like:
a=ssrc-group:FID 111 222a=ssrc:111 cname:...
This causes WebRTC clients (e.g., Chrome) to fail to parse the remote answer SDP.