Fixed blocky scrolling when changing filters on issues page #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixed the blocky scrolling on issues page when changing filter, Also added some room to the top of the page, so when it scrolls to top the text dont touch the browser window.
Also increased the max height of filter sidebar so it spreads to the bottom and now it looks good in browser window.
Benefits
The page scroll to top is smooth when changing filters now. also, improved user experience as no more blocky transitions. Larger filter wrapper makes the filter sidebar look good on the page.
Verification Process
Tested the new look in firefox and chrome and it works as expected.
Concerning Issues
W.R.T. #16